Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpublished package: Correct way to remove it from index? #586

Closed
LekoArts opened this issue Mar 8, 2021 · 2 comments 路 Fixed by #1140
Closed

Unpublished package: Correct way to remove it from index? #586

LekoArts opened this issue Mar 8, 2021 · 2 comments 路 Fixed by #1140

Comments

@LekoArts
Copy link

LekoArts commented Mar 8, 2021

Hi folks 馃憢

Over at our repository we got an issue gatsbyjs/gatsby#30058 that points to gatsby-uc/gatsby-plugin-ackee-tracker#69. Reading #556 I understand that normally the deletion on npm should account for that.

Is it still in the index because yarnpkg has it? https://yarnpkg.com/?q=gatsby-plugin-ackee
npm doesn't have it: https://www.npmjs.com/search?q=gatsby-plugin-ackee

Would deleting/unpublishing on yarnpkg resolve the issue? I want to spare y'all some work and get it done by robots 馃 as manually asking for deletions doesn't scale.

Thanks!

@Haroenv
Copy link
Collaborator

Haroenv commented Mar 8, 2021

I've deleted that package now manually, although it should have been done automatically following this:

npm-search/src/watch.js

Lines 187 to 195 in b40c6b2

changes.results = changes.results.filter(change => {
if (change.deleted) {
// Delete package directly in index
// Filter does not support async/await but there is no concurrency issue with this
mainIndex.deleteObject(change.id);
log.info(`馃殌 Deleted ${change.id}`);
}
return !change.deleted;
});

I haven't had time to debug this yet, but I saw that not every package on npm actually gets deleted. In the past we did a full reindex every week or two, but that became much too slow (the full reindex takes >1 week now, during which new packages don't get processed). If you could debug what's going on here, I'd gladly get you up to speed with the code base and credentials!

@LekoArts
Copy link
Author

LekoArts commented Mar 8, 2021

Thanks for the very quick answer, much appreciated!

While I'd love to dig into this and help resolve it, we're quite busy with our v3 release from last week and it's not a high priority at all for us. When we revisit that plugins page of our website it might come up again, but until then feel free to close this issue or keep it open (& not prioritized).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants