This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
fix(geolocation-permission): expose method to toggle useDeviceLocation #636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Google recommends not to ask for geolocation permission on page load but on user input.
This means that we need to have a way to modify the
useDeviceLocation
parameter outside of the instantiation step so that we can set it to true on user inputs.Result
setUseDeviceLocation
in places that allows you to modify theuseDeviceLocation
code after instantiation.On page load (tracking icon is not showing):
On pin click:
After pin click (tracking icon is showing):