feat(sortObject): Add a test for issue 344 (#357)

fixes #334
algolia · Jul 19, 2019 · 5fe7604 · 5fe7604
1 parent 8c6d6af
commit 5fe7604
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/src/formatter/sortObject.js b/src/formatter/sortObject.js
@@ -23,8 +23,13 @@ export default function sortObject(value: any): any {
       if (key === '_owner') {
         return result;
       }
-      // eslint-disable-next-line no-param-reassign
-      result[key] = sortObject(value[key]);
+      if (key === 'current') {
+        // eslint-disable-next-line no-param-reassign
+        result[key] = '[Circular]';
+      } else {
+        // eslint-disable-next-line no-param-reassign
+        result[key] = sortObject(value[key]);
+      }
       return result;
     }, {});
 }
diff --git a/src/index.spec.js b/src/index.spec.js
@@ -1126,4 +1126,27 @@ describe('reactElementToJSXString(ReactElement)', () => {
     }
     expect(mount(<App />).find('#hello')).toHaveLength(1);
   });
+
+  it('should not cause recursive loop when an element contains a ref', () => {
+    expect.assertions(1);
+    class App extends Component {
+      constructor(props) {
+        super(props);
+        this.inputRef = React.createRef();
+      }
+      componentDidMount() {
+        expect(reactElementToJSXString(<input ref={this.inputRef} />)).toEqual(
+          `<input
+  ref={{
+    current: '[Circular]'
+  }}
+ />`
+        );
+      }
+      render() {
+        return <input ref={this.inputRef} />;
+      }
+    }
+    mount(<App />);
+  });
 });