-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken using React 0.14 and NPM 2 #24
Comments
should be fixed now, let me know |
fixed. ty 👍 |
Sorry to resurrect this but, I'm having the same issue while using Not sure if |
Can you create a testing repo that is reproducing this so we can fix it? Or do you have a fix in mind? |
https://github.com/mgibeau/react-element-to-jsx-string_issue_24_sample As for a fix, it seems there are no clear cut solutions in this particular case. I think the most straight forward is to simply release separate versions that target different react versions (e.g.: 2.0 -> 0.14 vs 3.0 -> 15). Moving Otherwise, I guess a |
react-element-to-jsx-string
lists React 0.15 as a dependency, which npm 2 will complain about if an application uses React 0.14.FYI, I was pulling
"jsx-chai": "^2.0.0"
which in turn pullsreact-element-to-jsx-string
. npm 2 installs React 0.15 for you and then errors on invalid peer dependencies, because everything else in the application expects 0.14.The text was updated successfully, but these errors were encountered: