fix(formatting): Date/RegExp values output by formatComplexDataStructure #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with this Pull Request
|
lahmatiy
force-pushed
the
fix-format-complex-data-structure
branch
from
9dbbec8
to
a9e01e3
Compare
lahmatiy
changed the title
sortobject for own implementationsortobject for own implementation
lahmatiy
changed the title
sortobject for own implementation
armandabric
requested changes
Nov 14, 2017
| @@ -86,4 +86,20 @@ describe('formatComplexDataStructure', () => { | |||
| it('should format an empty array', () => { | |||
| expect(formatComplexDataStructure([], false, 0, options)).toEqual('[]'); | |||
| }); | |||
|
|
|||
| it('should format an object that contains a date', () => { | |||
There was a problem hiding this comment.
I guess theses tests are more related to sortObject behavior than the formatComplexDataStructure one. We should move then in the sortObject.spec.js file
There was a problem hiding this comment.
sortObject has its own test for that. I think left it here since not only sortObject is used to process objects and other logic can break things too.
src/formatter/sortObject.spec.js
Outdated
|
|
||
| import sortObject from './sortObject'; | ||
|
|
||
| describe('formatComplexDataStructure', () => { |
There was a problem hiding this comment.
Oups! Should be describe('sortObject', () => {
| c: date, | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Could you add a test that validate that sortObject could be directly call with array sortObject([{...}, {...}]);
lahmatiy
force-pushed
the
fix-format-complex-data-structure
branch
from
a9e01e3
to
c9060a7
Compare
|
Done :) |
armandabric
approved these changes
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sortobjectbreaks output of Date and RegExp values, since makes an object copy of those values instead returning as is. Therefore,formatComplexDataStructurefor following objectoutputs
We can fix
sortobjectby sending a PR. But its implementation is too verbose for such simple task. So I decided to add an own implementation ofsortObjectinstead of patchingsortobject. This also helps keep things simpler and allows adjust behaviour if needed.