-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): missing babel helpers, true esm modules, simplify #290
Conversation
Nice work @pascalduez, notify us when ready to go |
- This is already handled by babel-preset-flow
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
@vvo I think it's good to go. |
- Use Rollup for both cjs and esm build - Don't re-run babel on top preventing overrides
- Since only the typeof helper is used, it's much more simple and efficient to include it.
This fix works for me. The given example from #294
goes through without errors. |
- yarn run smoke cjs default | ||
- yarn run smoke esm default | ||
- yarn run smoke cjs latest | ||
- yarn run smoke esm latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hi,
babel-preset-flow
.esm
build is still transformed tocommonjs
, it's actually built two times.So this simplify a bit things, and leverage Rollup for what it's good at (handling multiple builds).
cjs
dir, flow-bin is a node tool.Only the
typeof
helper is used, so including it is amost costless. Including all helpers would,or requiring the users to install the plugin and including it in their code.