Add failing test for self empty jsx element that should equal an empty element as well #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y element as well
|
We can't have the function returning two different strings |
|
Seems to me a better test and fix would be to insert fake line breaks and spaces and make sure we do not have them in the output. Deal? |
|
Not sure about the whitespace. It's sort of opininated. I think that the assertion method (that is not part of this module right?) should handle the whitespace differences. |
Yes it depends on the assertion library, as I said expect.toIncludeJSX do not care about whitespace while expect.toEqualJSX does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #6