Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary string escaping #82

Merged
merged 2 commits into from
Jun 7, 2017
Merged

Fix unnecessary string escaping #82

merged 2 commits into from
Jun 7, 2017

Conversation

shouze
Copy link
Contributor

@shouze shouze commented May 30, 2017

Rel to #81

beauroberts and others added 2 commits May 26, 2017 13:15
@vvo
Copy link
Contributor

vvo commented Jun 3, 2017

I am kind of lost in my own code. Unable to see any shortcomings from this fix.

What about components that will have text containing ', " or ' as text?

@vvo vvo merged commit 5c0ae3e into algolia:master Jun 7, 2017
vvo pushed a commit that referenced this pull request Jun 7, 2017
@shouze shouze deleted the beauroberts-issue-80/unnecessary-string-escaping branch June 8, 2017 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants