fix(IndexUtils): avoid throw an error when cleanUp multi index (#1019)

algolia · Mar 1, 2018 · 865a3c3 · 865a3c3
1 parent b55b30a
commit 865a3c3
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/packages/react-instantsearch/src/core/indexUtils.js b/packages/react-instantsearch/src/core/indexUtils.js
@@ -189,7 +189,7 @@ export function getCurrentRefinementValue(
 export function cleanUpValue(searchState, context, id) {
   const index = getIndex(context);
   const { namespace, attributeName } = getNamespaceAndAttributeName(id);
-  if (hasMultipleIndex(context)) {
+  if (hasMultipleIndex(context) && Boolean(searchState.indices)) {
     return namespace
       ? {
           ...searchState,

diff --git a/packages/react-instantsearch/src/core/indexUtils.test.js b/packages/react-instantsearch/src/core/indexUtils.test.js
@@ -497,6 +497,20 @@ describe('utility method for manipulating the search state', () => {
           },
         },
       });
+
+      // When nothing is refine the searchState doesn't have the indices
+      // attribute even if we are in a context with <Index>. This should
+      // not happen, the searchState should always be in sync (indices + no values).
+      searchState = {
+        page: 1,
+      };
+
+      searchState = cleanUpValue(searchState, context, 'namespace.refinement');
+
+      expect(searchState).toEqual({
+        page: 1,
+        namespace: {},
+      });
     });
 
     it('get results', () => {