This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat: export highlight tags from DOM / native #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-instantsearch ready! Built with commit 4afd487 https://deploy-preview-1342--react-instantsearch.netlify.com |
Haroenv
reviewed
Jun 18, 2018
| @@ -1,5 +1,6 @@ | |||
| // Core | |||
| export { createConnector } from 'react-instantsearch-core'; | |||
| export { HIGHLIGHT_TAGS } from 'react-instantsearch-core'; | |||
There was a problem hiding this comment.
you can do those in the same export with ,
There was a problem hiding this comment.
Yep but I think it's a bit more easy to read with a separate statement.
Haroenv
approved these changes
Jun 18, 2018
samouss
added a commit
that referenced
this pull request
Jun 19, 2018
<a name="5.2.0-beta.2"></a> # [5.2.0-beta.2](v5.2.0-beta.1...v5.2.0-beta.2) (2018-06-19) ### Features * export highlight tags from DOM / native ([#1342](#1342)) ([28a699e](28a699e)) * **createInstantSearch:** enable _useRequestCache ([#1346](#1346)) ([f772600](f772600)) * **dom:** export create class name ([#1348](#1348)) ([9017468](9017468))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some cases you may want to have a very specific highlighting behaviour. For those use cases you will need to have access to the
highlighTagset by React InstantSearch (see Yarn website). You can still override the tags but it can be handy to use the one by default. Previously it was only exported by thecorepackage. Now you can access this value directly from DOM & Native.Before:
After: