This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(connectNumericMenu): support numeric refinement 0 #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
eunjae-lee and
yannickcr
and removed request for
a team
Haroenv
approved these changes
Dec 12, 2019
packages/react-instantsearch-core/src/connectors/__tests__/connectNumericMenu.js
Show resolved
Hide resolved
|
Could you add a story with an appropriate Algolia index? |
yannickcr
approved these changes
Dec 12, 2019
yannickcr
approved these changes
Dec 13, 2019
Haroenv
approved these changes
Dec 16, 2019
Haroenv
added a commit
that referenced
this pull request
Dec 17, 2019
# [6.1.0](v6.0.0...v6.1.0) (2019-12-17) ### Bug Fixes * **connectNumericMenu:** support numeric refinement 0 ([#2882](#2882)) ([30bd9fd](30bd9fd)) * **deps:** update dependency next to v9.1.1 ([9d49d33](9d49d33)) * **helper:** rely on stable version of algoliasearch-helper ([#2871](#2871)) ([e3531a1](e3531a1)) ### Features * **insights:** show an error when 'clickAnalytics: true' is missing. ([#2877](#2877)) ([621656a](621656a)) * **voice:** add additionalQueryParameters ([#2366](#2366)) ([3a45b2c](3a45b2c))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds in connectNumericMenu support for numericRefinement
0.There has been complaints about the following not producing a refinement
Result
fixes #867