This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(algoliasearch): add support for algoliasearch v4 #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickcr
force-pushed
the
feat/client-v4
branch
from
831c4b2
to
ec60e48
Compare
nunomaduro
suggested changes
Jan 15, 2020
Haroenv
reviewed
Jan 15, 2020
Haroenv
reviewed
Jan 15, 2020
packages/react-instantsearch-core/src/core/createInstantSearchManager.js
Show resolved
Hide resolved
packages/react-instantsearch-core/src/core/createInstantSearchManager.js
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-core/src/core/createInstantSearchManager.js
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-core/src/core/createInstantSearchManager.js
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-core/src/core/createInstantSearchManager.js
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-core/src/core/__tests__/createInstantSearchManager.js
Show resolved
Hide resolved
Co-Authored-By: François Chalifour <francoischalifour@users.noreply.github.com>
nunomaduro
suggested changes
Jan 24, 2020
packages/react-instantsearch-core/src/widgets/InstantSearch.tsx
Outdated
Show resolved
Hide resolved
nunomaduro
approved these changes
Jan 24, 2020
Haroenv
reviewed
Jan 24, 2020
packages/react-instantsearch-core/src/widgets/InstantSearch.tsx
Outdated
Show resolved
Hide resolved
Haroenv
reviewed
Jan 24, 2020
Haroenv
reviewed
Jan 29, 2020
Haroenv
approved these changes
Jan 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change add support for algoliasearch v4 to react-instantsearch.
Some changes were needed on cache hydration for the server-side rendering. The test suite must still be updated to support both v3 and v4 versions of algoliasearch client.
We also added a new job to CircleCI to test it against the version 3 of the client.