This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(RefinementList): prevent searchable component to refine on empty list #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
requested review from
a team,
tkrugg and
francoischalifour
and removed request for
a team
|
✔️ Deploy Preview for react-instantsearch ready! 🔨 Explore the source changes: f08e343 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-instantsearch/deploys/60bf8e03c0f4910007455d42 😎 Browse the preview: https://deploy-preview-3059--react-instantsearch.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f08e343:
|
francoischalifour
approved these changes
Jun 8, 2021
Haroenv
pushed a commit
that referenced
this pull request
Jun 28, 2021
Haroenv
pushed a commit
that referenced
this pull request
Jun 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevent the
RefinementListcomponent to refine when no items are in the list.Reproduction
noResultscomponentThe component tries to refine even though the list is empty (
Cannot read property 'value' of undefined), forcing the user to type again to make the facets reappear.Result
Pressing enter when the list is empty won't do anything.
Test
Following this comment, it seems that our storybook don't pick local changes, so you need to change the import in the story.
yarn storybook