This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(MenuSelect): Adds id prop to MenuSelect
#3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for react-instantsearch ready! 🔨 Explore the source changes: dad1bcd 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-instantsearch/deploys/60dc963753542f000707f051 😎 Browse the preview: https://deploy-preview-3073--react-instantsearch.netlify.app/storybook/iframe |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dad1bcd:
|
Haroenv
reviewed
Jun 30, 2021
packages/react-instantsearch-dom/src/components/__tests__/MenuSelect.js
Outdated
Show resolved
Hide resolved
joshpensky
force-pushed
the
fix/menuselect-id
branch
from
d701e38
to
5e6ea97
Compare
Haroenv
reviewed
Jun 30, 2021
stories/MenuSelect.stories.js
Outdated
| @@ -10,7 +10,7 @@ const stories = storiesOf('MenuSelect', module); | |||
| stories | |||
| .add('default', () => ( | |||
| <WrapWithHits hasPlayground={true} linkedStoryGroup="MenuSelect.stories.js"> | |||
| <MenuSelect attribute="brand" /> | |||
| <MenuSelect id="menu-select" attribute="brand" /> | |||
There was a problem hiding this comment.
Suggested change
| <MenuSelect id="menu-select" attribute="brand" /> | |
| <MenuSelect attribute="brand" /> |
joshpensky
force-pushed
the
fix/menuselect-id
branch
from
5e6ea97
to
dad1bcd
Compare
Haroenv
approved these changes
Jul 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an
idprop to theMenuSelectcomponent, in order to associate the element with alabelThis PR is a continuation of the work from #3068
Result
npm linkinpackages/react-instantsearch-domand root directory to sync package updateidto the defaultMenuSelectStorybook storyidprop appears in DOM