This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(server side rendering): return a value from mock currentRefinement/metadata #3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required, as transitionState gets called with the return of this; while the value isn't used anywhere really, it will cause an error if configure + currentRefinements is used in SSR context. (longer description to come once test is written)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 096ea23:
|
|
✔️ Deploy Preview for react-instantsearch ready! 🔨 Explore the source changes: 096ea23 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-instantsearch/deploys/6102c5481aff360008d3f82e 😎 Browse the preview: https://deploy-preview-3078--react-instantsearch.netlify.app |
Haroenv
changed the title
Haroenv
requested review from
a team,
tkrugg and
shortcuts
and removed request for
a team
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required, as transitionState gets called with the return of value in a createURL.
Without this fix, an error happens if there is:
The error is
TypeError: Cannot read properties of undefined (reading 'configure')as the transitionState argument is given the result of createURL/currentRefinements, but that's undefined instead of an object. The state isn't actually transitioned, so an empty object works as a solution.Here's a sandbox showing the existing state: https://codesandbox.io/s/charming-williamson-bifbf?file=/components/app.js:1158-1167
And that same sandbox fixed in this PR: https://codesandbox.io/s/bold-brook-gdyri