Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

feat(PoweredBy): update component logo #3661

Merged
merged 10 commits into from Oct 25, 2022
Merged

Conversation

FabienMotte
Copy link
Contributor

Summary

This PR updates the SVG of the <PoweredBy> widget component for react-instantsearch-dom and react-instantsearch-hooks-web and test snapshots.

@FabienMotte FabienMotte requested review from a team, sarahdayan and Haroenv and removed request for a team October 21, 2022 10:56
@FabienMotte FabienMotte changed the title feat(poweredBy): update component logo feat(PoweredBy): update component logo Oct 21, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 21, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 490b6cc:

Sandbox Source
react-instantsearch-app Configuration
hooks-example Configuration

@netlify
Copy link

netlify bot commented Oct 21, 2022

Deploy Preview for react-instantsearch ready!

Name Link
🔨 Latest commit ba35e8e
🔍 Latest deploy log https://app.netlify.com/sites/react-instantsearch/deploys/63527ac4074bb80008615865
😎 Deploy Preview https://deploy-preview-3661--react-instantsearch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 21, 2022

Deploy Preview for react-instantsearch ready!

Name Link
🔨 Latest commit 490b6cc
🔍 Latest deploy log https://app.netlify.com/sites/react-instantsearch/deploys/6357a5a0e38243000987bffa
😎 Deploy Preview https://deploy-preview-3661--react-instantsearch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarahdayan
Copy link
Member

sarahdayan commented Oct 21, 2022

I see a missing space between the text and logo on React InstantSearch v6 (sandbox).

Capture d’écran 2022-10-21 à 13 09 25

@FabienMotte
Copy link
Contributor Author

FabienMotte commented Oct 21, 2022

I see a missing space between the text and logo on React InstantSearch v6 (sandbox).

Capture d’écran 2022-10-21 à 13 09 25

@sarahdayan It looks like we have a margin-left: 0.3rem on RIS Storybook but I'm not sure where that's coming from

image

@sarahdayan
Copy link
Member

sarahdayan commented Oct 21, 2022

@FabienMotte It's from the Algolia theme while the sandbox uses the Satellite theme.

@FabienMotte
Copy link
Contributor Author

FabienMotte commented Oct 21, 2022

@sarahdayan Oh I see, so we had the issue before: https://codesandbox.io/s/react-instantsearch-app-forked-xyf9lu
How do you think we should solve this?

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving a review so I know when height is added again :)

@sarahdayan
Copy link
Member

@FabienMotte Since the issue was already here, we can fix it separately.

Let's make sure we constrain the size of the SVG in this PR, then feel free to open another one to add the margin (can be done after this one is merged).

@Haroenv
Copy link
Contributor

Haroenv commented Oct 25, 2022

@FabienMotte
Copy link
Contributor Author

@Haroenv I did update them but forgot to build before, doing it right now

@FabienMotte FabienMotte merged commit 69c1b2a into master Oct 25, 2022
@FabienMotte FabienMotte deleted the feat/powered-by-update branch October 25, 2022 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants