This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix: reset page with multi index #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 3e7f4dc |
samouss
force-pushed
the
fix/reset-page-multi-index
branch
2 times, most recently
from
a3ae472
to
694aa18
Compare
|
Looks good |
samouss
force-pushed
the
fix/reset-page-multi-index
branch
from
694aa18
to
c828f94
Compare
|
@mthuret any blockers about it? |
samouss
force-pushed
the
fix/reset-page-multi-index
branch
from
c828f94
to
3e7f4dc
Compare
samouss
added a commit
that referenced
this pull request
Dec 20, 2017
<a name="4.3.0"></a> * reset page with multi index ([#665](#665)) ([865b7dc](865b7dc)) * **SearchBox:** use hidden over style to hide loader ([#714](#714)) ([ed5eb77](ed5eb77)) * test recipes ([#740](#740)) ([de2cc37](de2cc37)) * track all index in the manager ([#660](#660)) ([793502b](793502b)) * loading indicator ([#544](#544)) ([189659e](189659e)) * **Highlight:** support array of strings ([#715](#715)) ([8e93c6a](8e93c6a))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #637
With the multi indices we always reset the page when a shared widget is updated even when
resetPageproperty is not passed. This PR aims to fix this, now we reset the page only the property is provided.Result
We can play the example on Storybook.