This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(connectRange): check if facet exist before access #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouss
force-pushed
the
fix/connect-range-facet-access
branch
from
ccc3a2d
to
9952766
Compare
|
Deploy preview ready! Built with commit 04f2e07 |
samouss
force-pushed
the
fix/connect-range-facet-access
branch
4 times, most recently
from
169e330
to
83f98d8
Compare
samouss
force-pushed
the
fix/connect-range-facet-access
branch
2 times, most recently
from
b7acfcc
to
6505f85
Compare
samouss
force-pushed
the
fix/connect-range-facet-access
branch
from
6505f85
to
735b21b
Compare
Haroenv
suggested changes
Jan 8, 2018
| @@ -190,8 +190,13 @@ export default createConnector({ | |||
| getProvidedProps(props, searchState, searchResults) { | |||
| const { attributeName, precision, min: minBound, max: maxBound } = props; | |||
| const results = getResults(searchResults, this.context); | |||
| const stats = results ? results.getFacetStats(attributeName) || {} : {}; | |||
| const count = results | |||
| const isFacetExist = results && results.getFacetByName(attributeName); | |||
There was a problem hiding this comment.
facetExists seems like a better name
There was a problem hiding this comment.
I prefer to prefix all the boolean value like one with is or has it make them explicit. Would you agree for isFacetExists ?
There was a problem hiding this comment.
makes sense, but grammatically it reads weird. What about hasFacet as something which matches the pattern but also grammar?
|
@Haroenv should be good now! |
Haroenv
approved these changes
Jan 8, 2018
samouss
added a commit
that referenced
this pull request
Jan 9, 2018
<a name="4.4.1"></a> ## [4.4.1](v4.4.0...v4.4.1) (2018-01-09) ### Bug Fixes * **SearchBox**: clear SearchBox without search as you type ([#802](#802)) ([c49b2b6](c49b2b6)) * **connectRange:** check if facet exist before access ([#797](#797)) ([6520760](6520760)) * **stories:** avoid to use linear-background it breaks Argos every time ([#804](#804)) ([0beded7](0beded7)) * **stories:** limit hits per page on Index ([#806](#806)) ([6eb14d3](6eb14d3)) ### Features * **Index:** allow custom root ([#792](#792)) ([d793b0a](d793b0a))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #630
In the
connectRangewe need to access the stats & the values of the given facet in order to compute the range. But it may happen that the facet is not yet present on the results so we need to check that the facet is present on results before accessing it.