feat: Instructions for manual enabling of permission #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Flow for manual enabling of recording permission.
whyAllow
,buttonAllow
), and the manual instructions' message/CTA/instructions (whyEnable
,buttonEnable
,howEnable
)Voice.openAppSettings()
from their own UI logicQuestions
As
showPermissionRationale
andshowPermissionManualInstructions
have two overloads forString
andStringRes
parameters, default arguments caused anOverload resolution ambiguity
. The solution I found was a third overload with the minimum amount of arguments, but let me know if you have a better approach!WDYT of refactoring all those as
Activity.*
extension methods? I feel it improves DX by allowingthis.showX()
instead ofVoice.showX(this)
, but might pollute the scope/prevent discoverability (for example withActivity.openAppSettings()
). @q-litzler what's your take on this?Documenting overloads results in duplicated documentation. Is there a way to avoid that or is it a necessary evil? 馃