Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/customization #11

Merged
merged 5 commits into from Sep 19, 2018
Merged

Feat/customization #11

merged 5 commits into from Sep 19, 2018

Conversation

PLNech
Copy link
Member

@PLNech PLNech commented Sep 17, 2018

  • Expose autoStop
  • Expose Extension functions whenever valuable

    e.g. I felt turning isPermissionGranted(grantResult: IntArray) into IntArray.isPermissionGranted() would make sense, but only if done consistently with isRecordPermissionWithResults.
    As both Int.isRecordPermissionWithResults(grantResults: IntArray) and IntArray.isRecordPermissionWithResults(requestCode: Int) would feel weird, I stuck with staticness for both functions.

  • Add @JVMOverloads when it improves Java DX

@PLNech PLNech self-assigned this Sep 17, 2018
Copy link
Contributor

@q-litzler q-litzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny detail over setters return value as expression.

@PLNech PLNech dismissed q-litzler’s stale review September 19, 2018 16:38

Thanks, reverted to block body.

@PLNech PLNech merged commit b028af5 into master Sep 19, 2018
@PLNech PLNech deleted the feat/customization branch September 19, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants