Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.1: Some fixes and a demo app #4

Merged
merged 29 commits into from Aug 27, 2018
Merged

v2.1: Some fixes and a demo app #4

merged 29 commits into from Aug 27, 2018

Conversation

PLNech
Copy link
Member

@PLNech PLNech commented Aug 17, 2018 •
edited

Update: separated VoiceInput from presenter, see #5
Refactoring:

  • Update import value
  • Leverage requireActivity in PDF

API Improvements:

  • only require List in VDF's listener

Fixes:

  • fix missing negation in Voice.hasRecordPermission

@PLNech PLNech requested a review from q-litzler August 17, 2018 15:28
PLNech and others added 24 commits August 17, 2018 18:11
@PLNech
feat(VoiceDialogFragment): Expose parameter for recognized language
0eee4d3
@PLNech
chore: Add fixme for handling orientation changes
2a80d3c
@PLNech
refactor(VDF): rename languageCode to language
320aec1
@PLNech
feat(VoiceDialogFragment): Expose parameter for number of results
e03081d
@PLNech
chore: Add VERSION_SUPPORT in top build.gradle
177f30f
@PLNech
refactor(VDF): use activity as default listener
d3d4468
@PLNech
chore(VDF): add missing endregion
57ea6c1
@PLNech
fix(ViewRipple): Overcome early calls to cancel
1b5f5a1
@PLNech
refactor: Extract VoiceInput from VDF
4014e4c
@PLNech
refactor(VoiceInput): Simplify buildMatchesString, template strings
d348c37
@PLNech
style: Better layouts, extract string resource
b86af69
@q-litzler
style: Kotlin guidelines
e2687fc
@q-litzler
style: Add line break end of file
11605b3
@q-litzler
style: Use object for Voice
1bb3191
@q-litzler
style: Kotlin guidelines
98747a2
@q-litzler
refactor: Permission dialog now uses arguments.
ef2f540
@PLNech
Merge pull request #7 from algolia/feature/permission-dialog-fragment
332f1db 
refactor: Permission dialog now uses arguments.
@PLNech
Merge pull request #6 from algolia/feature/feat/kotlin-guidelines
c051f8c 
Feature/feat/kotlin guidelines
@PLNech
chore(app): update appcompat to 28-rc1
0575ec7
@PLNech
fix(VDM): No lazy loading
49d8d51
@PLNech
chore(PDF): Expose overloads for buildArguments
8e75847
@PLNech
refactor(VDF): get rid of view.let
2ac2767
@PLNech
style: Newline after class opening
ebaab79
@PLNech
Merge pull request #5 from algolia/feat/separateVoiceInput
b0f5325 
Separate voice input from presenting fragment
@PLNech PLNech merged commit a1c1900 into feat/v2 Aug 27, 2018
@PLNech PLNech deleted the feat/v2.1 branch August 27, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@q-litzler q-litzler q-litzler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PLNech @q-litzler