Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when first request permission #22

Closed
fadielse opened this issue Aug 19, 2019 · 7 comments · Fixed by #24
Closed

Crash when first request permission #22

fadielse opened this issue Aug 19, 2019 · 7 comments · Fixed by #24

Comments

@fadielse
Copy link

hi thanks for this cool library, but I found a problem when my serachController is in the tabBarController

when it was my first request for permission and I allowed it, the application crashed and after the application was reopened everything went smoothly. but then the problem arises again because when the input page appears the menu on the tabbar is not overwritten like the permission page.

I really appreciate if you help me solve the problem, cheers

@marcelfagadariu
Copy link

hi thanks for this cool library, but I found a problem when my serachController is in the tabBarController

when it was my first request for permission and I allowed it, the application crashed and after the application was reopened everything went smoothly. but then the problem arises again because when the input page appears the menu on the tabbar is not overwritten like the permission page.

I really appreciate if you help me solve the problem, cheers

Hey. Did you solve this issue? It still crashes my app for the first time when it request permissios

@ShaiAlkoby
Copy link
Contributor

@marcelfagadariu @fadielse did any of you manage to solve this problem?

@marcelfagadariu
Copy link

@marcelfagadariu @fadielse did any of you manage to solve this problem?

Sadly, no, still crashing. Any idea if any delegate method is called if the close button is pressed? Can't find any

@vuongle1705
Copy link

Yes, I met the same issue. I've tried in iOS 12 and iOS 13 as well, I think this bug only happens with iOS 13. I didnt met this bug in iOS 12.

@selini
Copy link

selini commented Nov 12, 2019

Same here. I have the same issue in iOS 13

@fadielse
Copy link
Author

hi thanks for this cool library, but I found a problem when my serachController is in the tabBarController

when it was my first request for permission and I allowed it, the application crashed and after the application was reopened everything went smoothly. but then the problem arises again because when the input page appears the menu on the tabbar is not overwritten like the permission page.

I really appreciate if you help me solve the problem, cheers

apparently there are many who experienced the same thing with me.

waiting for the fix for the bug, I tried to request permissions outside of this library and it worked.

maybe a little sample of my code:

import AVFoundation
import Speech

//put this code whereever you want ex: appdelegate / voice page
AVAudioSession.sharedInstance (). RequestRecordPermission {_ in}
SFSpeechRecognizer.requestAuthorization {_ in}

@spinach
Copy link
Contributor

spinach commented Nov 19, 2019

Hello,

Sorry for the very late reply here. Just submitted version 1.1.0 that should fix the issue. You can run pod update to get it. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants