This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
add page class for "page" item #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bb0dec3:
|
|
This seems correct, although the tests need to be updated to take the new class in account. Are you able to run it locally? |
|
@Haroenv Unfortunately not. Can you edit the PR by yourself? |
|
I added the class to the snapshot file. Maybe the tests are correct now. |
|
Ok, I got it:
PASS src/components/tests/Pagination.js (11.345s) Seems to pass. But there is no specific test for matching |
Haroenv
approved these changes
Jun 28, 2022
Haroenv
pushed a commit
that referenced
this pull request
Jun 28, 2022
* add page class for "page" item * add ais-Pagination-item--page class to Pagination snapshot
Haroenv
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
…earch#1129) * add page class for "page" item * add ais-Pagination-item--page class to Pagination snapshot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1128