Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some questions about your paper #45

Closed
zinuoli opened this issue Apr 12, 2024 · 2 comments
Closed

Some questions about your paper #45

zinuoli opened this issue Apr 12, 2024 · 2 comments

Comments

@zinuoli
Copy link

zinuoli commented Apr 12, 2024

Hi, sorry for the distrubance again, I got some ambiguous points after reading your paper:

  1. Do you train CLIP Controller and Restoration Model separtely or train they at the same time?
  2. I saw you introduce learnable prompt at this line, which is smart. However, I notice you incorporate prompt_embedding by t = t + prompt_embedding, my question is why you integrate degradation type into time step, instead of by cross attention like this x = attn(x, context=image_context).
  3. For the NAFNet there's no time step, how did you integrate prompt_embedding into NAFNet?

Something I didn't find answer in your paper (or I missed), sorry for interrupting you. Thank you for your great work.

@Algolzw
Copy link
Owner

Algolzw commented Apr 12, 2024

Hi,

  1. I train the two models separately.
  2. I directly add the prompt_embedding to time_embedding for model efficiency since we already have cross-attentions for the image_context.
  3. For the modified NAFNet (with time embeddings), you can refer to the Refusion's code here.

@zinuoli
Copy link
Author

zinuoli commented Apr 12, 2024

Got it, thank you so much.😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants