Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extended support for HapicFile #171

Open
inkhey opened this issue Mar 27, 2019 · 0 comments
Open

Add extended support for HapicFile #171

inkhey opened this issue Mar 27, 2019 · 0 comments

Comments

@inkhey
Copy link
Contributor

inkhey commented Mar 27, 2019

Currently:
with #153, we allow support for :
return HapicFile(file_path='/tmp/myfile.png')
with any supported framework.

Only Pyramid support file_object and others params correctly.

Expected:

  • Support File object for all framework
  • Support additional params for all framework (mimetype, content_length, ...) in both file_path and file_object case. Additional param like those, should override default_value.
  • Make code more generic without using specific method from framework, prefer to change headers directly and deal to provide almost same result for all framework. This may be tricky as for supporting some complex feature like http range.
  • Support for Range and conditional request in other framework than pyramid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant