Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for line plot in Example 9.8 #106

Closed
wuzh07 opened this issue Aug 29, 2023 · 6 comments
Closed

Suggestion for line plot in Example 9.8 #106

wuzh07 opened this issue Aug 29, 2023 · 6 comments
Assignees

Comments

@wuzh07
Copy link

wuzh07 commented Aug 29, 2023

The colors of "random rollout" (102,110,185) and "lookahead" (25,117,185) in the line plot in Example 9.8 are confusing for individuals with red-green color blindness (like me). It is greatly appreciated if a color blind-friendly palette is adopted or legends are diversified in different aspects (e.g. color, marker ...). Thank you very much.

@mykelk
Copy link
Contributor

mykelk commented Aug 29, 2023

Thanks for the note! I agree, those two lines look very similar in color (even for those without colorblindness). As mentioned in the acknowledgment section, we optimized the general color scheme to be colorblind friendly, but this line will need some work. I'll assign Tim to this issue since he has the keenest sense of aesthetics and might have some thoughts on the best correction.

@tawheeler
Copy link
Collaborator

tawheeler commented Aug 30, 2023

Hello wuzh07, I am changing the line plot to have varied marker types:
image

Hope that helps!

@tawheeler
Copy link
Collaborator

Please let me know if you would like to be acknowledged, in which case I would need your first and last name.

@tawheeler
Copy link
Collaborator

@wuzh07, could you please let us know what you think of this use of orange instead of the offending purple line? This plot would let us keep our consistent style of only using circular markers.

image

@wuzh07
Copy link
Author

wuzh07 commented Aug 30, 2023

@tawheeler The latest one works pretty well for me and I can tell different lines easily. My name is Zhen Wu and thank you again for your consideration.

@tawheeler
Copy link
Collaborator

Perfect, we'll go with that then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants