Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to double-click to zoom on first page #39

Closed
mirkancal opened this issue Apr 28, 2023 · 7 comments
Closed

Unable to double-click to zoom on first page #39

mirkancal opened this issue Apr 28, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@mirkancal
Copy link

When you open a pdf and you double tap, it doesn't zoom. You need to swipe to second page and come back to make double tap zoom work.

@andreBalh
Copy link
Collaborator

Hi @mirkancal
Thank you for opening the issue.
Could you provide more information about the device where that issue happened? @mirkancal

@andreBalh andreBalh added the bug Something isn't working label Apr 28, 2023
@mirkancal
Copy link
Author

@andreBalh I caught the issue on iPhone. Tested on simulator and iPhone 12 pro max.

@andreBalh
Copy link
Collaborator

I checked your issue. It looks like the double tap is just zooming out a little bit. That means that the default zoom value is wrong and has to be fixed.
I will try to fix that. @mirkancal

@mirkancal
Copy link
Author

@andreBalh thank you. Interesting, on my end double tap doesn't do anything on initial page but pinch to zoom works immediately. To make double tap work, I need to move to another page.

@andreBalh
Copy link
Collaborator

I think I could fix the issue, could you change the following for alh_pdf_view in your pubspec.yaml and try that update if that fix your issue? @mirkancal

... 
alh_pdf_view: 
  git: 
    url: https://github.com/alhappler/alh_pdf_view.git 
    ref: dcf69a413d7f27ccf21adc7ffe80f7a48b3ed76e 
...

@mirkancal
Copy link
Author

Thank you, seems fixed to me.

@andreBalh
Copy link
Collaborator

Should be fixed with version 1.2.1. @mirkancal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants