Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not IGauge be moved to Abstractions? #104

Closed
mikefonted opened this issue Mar 22, 2017 · 1 comment
Closed

Should not IGauge be moved to Abstractions? #104

mikefonted opened this issue Mar 22, 2017 · 1 comment
Labels
refactoring
Projects
1.1.0-alpha
Milestone
1.1.0-alpha

Comments

@mikefonted
Copy link

Hi,
I found IGauge out of its own Abstraction folder/namespace.
However, it is not the case for IHistogram, IMeter, ITimer...
Is there a solid reason for this?
@alhardy
Copy link
Collaborator

alhardy commented Mar 22, 2017

@mikefonted good spotting, no there's no reason for that, just missed as part of refactoring I guess

@alhardy alhardy added this to the 1.1.0-alpha milestone Mar 28, 2017
@alhardy alhardy added this to TODO in 1.1.0-alpha Mar 28, 2017
@alhardy alhardy moved this from TODO to In Progress in 1.1.0-alpha Apr 2, 2017
alhardy added a commit that referenced this issue Apr 2, 2017
@alhardy
#104 namespace consistency on IGauge
15004d4
@alhardy alhardy moved this from In Progress to Ready for Release in 1.1.0-alpha Apr 2, 2017
@alhardy alhardy closed this as completed Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
No open projects
1.1.0-alpha
Ready for Release
Milestone
1.1.0-alpha
Development

No branches or pull requests
2 participants
@alhardy @mikefonted