Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code duplication in ES & InfluxDB reporters #105

Closed
5 tasks done
alhardy opened this issue Mar 23, 2017 · 0 comments
Closed
5 tasks done

Remove code duplication in ES & InfluxDB reporters #105

alhardy opened this issue Mar 23, 2017 · 0 comments
Labels
refactoring
Projects
1.1.0-alpha
Milestone
1.1.0-alpha

Comments

@alhardy
Copy link
Collaborator

alhardy commented Mar 23, 2017 •
edited

See AppMetrics/Reporting#13

  • Add dictionary extensions
  • Make NoOpMetricsFilter public
  • Make metric payload builder and extensions re-usable so that it can be re-used across reporters
  • Allow custom metric value keys when reporting
  • Make report run generic so that it can be used across reporter implementations
@alhardy alhardy mentioned this issue Mar 23, 2017
Closed
@alhardy alhardy added this to TODO in 1.1.0-alpha Mar 28, 2017
@alhardy alhardy added this to the 1.1.0-alpha milestone Mar 28, 2017
@alhardy alhardy moved this from TODO to In Progress in 1.1.0-alpha Apr 7, 2017
alhardy added a commit that referenced this issue Apr 7, 2017
@alhardy
#105 adding dictionary extensions and making NoOpMetricsFilter public…
3f3ca97 
… to support sharing between reporters
alhardy added a commit that referenced this issue Apr 7, 2017
@alhardy
#105 debugger step through on dictionary extensions
6515763
alhardy added a commit that referenced this issue Apr 11, 2017
@alhardy
#105 Moving metric payload builder and extension methods from reporti…
4551d19 
…ng report and making more generic to re-use between reporters
alhardy added a commit that referenced this issue Apr 11, 2017
@alhardy
#105 fixing incorrect tag key for percentage tag on counters'
516084e
@alhardy alhardy moved this from In Progress to Ready for Release in 1.1.0-alpha Apr 11, 2017
@alhardy alhardy moved this from Ready for Release to Needs Testing in 1.1.0-alpha Apr 11, 2017
@alhardy alhardy moved this from Needs Testing to In Progress in 1.1.0-alpha Apr 11, 2017
@alhardy alhardy mentioned this issue Apr 11, 2017
Closed
alhardy added a commit that referenced this issue Apr 12, 2017
@alhardy
#105 allowing custom metric values keys on reporting, moved metric va…
b88ab45 
…lue extensions from influx report to be shared across reporters
alhardy added a commit that referenced this issue Apr 12, 2017
@alhardy
#105 adding custom data keys class to metric report settings interfac…
f6b3d56 
…e to allow clients to customise and use withing a reporter
alhardy added a commit that referenced this issue Apr 12, 2017
@alhardy
#105 re-applying default histogram count data key
a298301
alhardy added a commit that referenced this issue Apr 12, 2017
@alhardy
#105 BUILDFIX - re-applying default histogram count data key
b923b5b
alhardy added a commit that referenced this issue Apr 13, 2017
@alhardy
#105 adding meter mean rate if not nan or infinity, adding metric rep…
086348e 
…ort/pack tests
alhardy added a commit that referenced this issue Apr 13, 2017
@alhardy
#105 allow overriding counter total and percent data keys on reporting
9d07ae3
alhardy added a commit that referenced this issue Apr 13, 2017
@alhardy
#105 clean up metric value data keys, only need to instantiate and me…
edef6e0 
…rge dictionaries once
alhardy added a commit that referenced this issue Apr 13, 2017
@alhardy
#105 allow customizing metric set item key
88575cc
alhardy added a commit that referenced this issue Apr 13, 2017
@alhardy
#105 adding report running to simplify reporter implementations
5ae853f
@alhardy alhardy moved this from In Progress to Ready for Release in 1.1.0-alpha Apr 13, 2017
@alhardy alhardy closed this as completed Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
No open projects
1.1.0-alpha
Ready for Release
Milestone
1.1.0-alpha
Development

No branches or pull requests
1 participant
@alhardy