We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repro:
var services = new ServiceCollection(); services.AddLogging(); services.AddOptions(); services.AddMetrics(); var metrics = services.BuildServiceProvider().GetService<IMetrics>(); var timerDef = new TimerOptions() { Reservoir = new Lazy<IReservoir>(() => new DefaultForwardDecayingReservoir()) }; var timer1 = metrics.Provider.Timer.Instance(timerDef, new MetricTags("test", "1")); var timer2 = metrics.Provider.Timer.Instance(timerDef, new MetricTags("test", "2")); timer1.Record(100, TimeUnit.Seconds); timer1.Record(100, TimeUnit.Seconds); timer1.Record(100, TimeUnit.Seconds); timer1.Record(100, TimeUnit.Seconds); timer1.Record(100, TimeUnit.Seconds); var timers = metrics.Snapshot.Get().Contexts.First().Timers.ToArray(); Assert.Equal(5, timers[0].Value.Histogram.Count); Assert.Equal(100_000, timers[0].Value.Histogram.Mean); Assert.Equal(0, timers[1].Value.Histogram.Mean); Assert.Equal(0, timers[1].Value.Histogram.Count);
Full project with that test: AppMetricsBug.zip
The text was updated successfully, but these errors were encountered:
#107 [Bugfix] Reservoirs shared when metric is multidimentional
d8433f5
Passing test: d8433f5#diff-c0adf07e63a5b1bb37151239eee1d263R200
Sorry, something went wrong.
No branches or pull requests
Repro:
Full project with that test:
AppMetricsBug.zip
The text was updated successfully, but these errors were encountered: