Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging unhandled exceptions as 500 error #109

Closed
alhardy opened this issue Mar 29, 2017 · 2 comments
Closed

Logging unhandled exceptions as 500 error #109

alhardy opened this issue Mar 29, 2017 · 2 comments
Labels
bug
Projects
1.1.0-alpha
Milestone
1.1.0-alpha

Comments

@alhardy
Copy link
Collaborator

alhardy commented Mar 29, 2017 •
edited

#108
@alhardy alhardy added this to the 1.1.0-alpha milestone Mar 29, 2017
@alhardy alhardy added this to Needs Testing in 1.1.0-alpha Mar 29, 2017
alhardy added a commit that referenced this issue Mar 29, 2017
@alhardy
#109 error meter middleware should still throw the exception, but als…
eb524ad 
…o track the error'
@alhardy
Copy link
Collaborator Author

alhardy commented Mar 29, 2017

@djturner1984 Actually, we probably still want to throw the exception yeah? eb524ad

@djturner1984
Copy link

@alhardy yeah you're right, otherwise the middleware will swallow the exception. I think if we add a throw; in the catch it will rethrow the exception and the finally will still execute with the 500 status code. I'll send through another PR for this

alhardy added a commit that referenced this issue Apr 2, 2017
@alhardy
#109 Active requests should not be effected when exceptions thrown
8b232cf
@alhardy alhardy moved this from Needs Testing to Ready for Release in 1.1.0-alpha Apr 2, 2017
@alhardy alhardy closed this as completed Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
No open projects
1.1.0-alpha
Ready for Release
Milestone
1.1.0-alpha
Development

No branches or pull requests
2 participants
@alhardy @djturner1984