Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on machines with different number format due to bug in aspnet/Configuration #123

Closed
cwe1ss opened this issue Apr 21, 2017 · 0 comments
Labels
Projects
Milestone

Comments

@cwe1ss
Copy link
Contributor

cwe1ss commented Apr 21, 2017

.\test\App.Metrics.Extensions.Middleware.Integration.Facts\DependencyInjection\TestConfiguration\appsettings.json currently contains the line "ApdexTSeconds": 0.8.

Unfortunately, there is a bug in aspnet/Configuration which results in a culture mismatch (the JSON parser writes "0,8" (using CurrentCulture) and IConfiguration.GetValue uses InvariantCulture).

As a result, the following tests fail:

AspNetMetricsCoreBuilderExtensionsTests (2 tests) [0:00.672] Failed: 2 tests failed
   can_load_settings_from_configuration [0:00.018] Failed: Did not expect any exception, but found System.InvalidOperationException with message "Failed to convert '0,8' to type 'System.Double'."
   can_override_settings_from_configuration [0:00.654] Failed: Did not expect any exception, but found System.InvalidOperationException with message "Failed to convert '0,8' to type 'System.Double'."

The suggested workaround is to use "ApdexTSeconds": "0.8" instead.

@alhardy alhardy added this to the 1.1.1 milestone Apr 22, 2017
alhardy added a commit that referenced this issue Apr 22, 2017
#123 config tests fail for cultures with different number formats
@alhardy alhardy closed this as completed Apr 22, 2017
@alhardy alhardy added this to TODO in 1.1.1 Apr 27, 2017
@alhardy alhardy moved this from TODO to Read to Release in 1.1.1 Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
1.1.1
Read to Release
Development

No branches or pull requests

2 participants