Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app.UseMetricsReporting blocks on RunReports #129

Closed
alhardy opened this issue Apr 27, 2017 · 2 comments
Closed

app.UseMetricsReporting blocks on RunReports #129

alhardy opened this issue Apr 27, 2017 · 2 comments
Labels
Projects
Milestone

Comments

@alhardy
Copy link
Collaborator

alhardy commented Apr 27, 2017

Calling run reports blocks waiting for the reporter thread to finish but this is long running for the lifetime of the app.

lifetime.ApplicationStarted.Register(
                () =>
                {
                    reporter.RunReports(metrics, appLifetime.ApplicationStopping);
                });
@alhardy alhardy created this issue from a note in 1.1.1 (TODO) Apr 27, 2017
@alhardy alhardy changed the title app.UseMetricsReporting blocks on RunReports app.UseMetricsReporting blocks on RunReports Apr 27, 2017
@alhardy alhardy added the 1.1.1 label Apr 27, 2017
@alhardy alhardy added this to the 1.1.1 milestone Apr 27, 2017
@alhardy alhardy moved this from TODO to Read to Release in 1.1.1 Apr 27, 2017
@alhardy alhardy closed this as completed Apr 27, 2017
@alhardy alhardy added the bug label Apr 27, 2017
@vinh84
Copy link

vinh84 commented Apr 28, 2017

@alhardy please push App.Metrics.Extensions.Middleware 1.1.1 to nuget for milestone 1.1.1
you miss it

@alhardy
Copy link
Collaborator Author

alhardy commented Apr 28, 2017

@vinhhrv pushed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
1.1.1
Read to Release
Development

No branches or pull requests

2 participants