Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finialize all api contracts #50

Closed
alhardy opened this issue Dec 23, 2016 · 3 comments
Closed

Finialize all api contracts #50

alhardy opened this issue Dec 23, 2016 · 3 comments
Labels
breaking change
Milestone
1.0.0-beta5

Comments

@alhardy
Copy link
Collaborator

alhardy commented Dec 23, 2016 •
edited

Review the IMetrics contract to avoid breaking changes before bumping to rc.

  • the default IMetrics implementation includes measuring all metrics, seperate this by metric type and expose an api into measurement methods by metric type to allow better discoverabily and a clearer api.
  • move sampling implementation from appmetrics core project to its own, may replace some functionality in future with hdrhistogram.net and math.net packages.
  • potentially expose hit ratio and other gauge types on the meyrics api for better discover and ease of use.
  • IAdvancedMetrics can be improved in the same way as mentioned in the first point above.
@alhardy alhardy added this to the 1.0.0-beta4 milestone Dec 23, 2016
@alhardy alhardy modified the milestones: 1.0.0-beta4, 1.0.0-beta5 Jan 3, 2017
@alhardy alhardy changed the title Review IMetrics contract Finialize IMetrics contract Jan 7, 2017
alhardy added a commit that referenced this issue Jan 14, 2017
@alhardy
#50 adding measure metric interfaces grouping contracts by metric type
5a1591c
alhardy added a commit that referenced this issue Jan 15, 2017
@alhardy
#50 cleaning up metrics contract and implementation
82e12ca
@alhardy alhardy changed the title Finialize IMetrics contract Finialize all api contracts Jan 15, 2017
alhardy added a commit that referenced this issue Jan 16, 2017
@alhardy
#50 adding metric manager tests
fb16830
alhardy added a commit that referenced this issue Jan 18, 2017
@alhardy
#50 metrics now recorded through a manager per type, removed IAdvance…
ec869ab 
…dMetrics and instead exposed access to data, health and custom metrics through sepearte managers
alhardy added a commit that referenced this issue Jan 18, 2017
@alhardy
#50 groping metrics managers in IMetrics
7ea394f
alhardy added a commit that referenced this issue Jan 18, 2017
@alhardy
#50 renaming advanced metric contracts
2144668
alhardy added a commit that referenced this issue Jan 18, 2017
@alhardy
#50 renaming properties on IMetrics
e993021
alhardy added a commit that referenced this issue Jan 19, 2017
@alhardy
#50 renaming advanced managers to metric providers since they return …
3a52803 
…a metric instance after adding to the registry
alhardy added a commit that referenced this issue Jan 20, 2017
@alhardy
#50 refactoring metrics, adding metric builders, providers and manage…
3f30463 
…rs with tests
alhardy added a commit that referenced this issue Jan 20, 2017
@alhardy
#50 just adding comments
b3fcbd1
@alhardy
Copy link
Collaborator Author

alhardy commented Jan 20, 2017

updated samples in dotnet 452 solution AppMetrics/Samples@372335c

@alhardy
Copy link
Collaborator Author

alhardy commented Jan 20, 2017

updated samples in dotnet core solution AppMetrics/Samples@f2d2a17

@alhardy
Copy link
Collaborator Author

alhardy commented Jan 20, 2017

updated owin packages alhardy/AppMetrics.Owin@3a8f5e8

@alhardy alhardy closed this as completed Jan 20, 2017
alhardy added a commit that referenced this issue Jan 27, 2017
@alhardy
#50 refacting namspaces, grouping into features
350d5ae
alhardy added a commit that referenced this issue Jan 27, 2017
@alhardy
#50 refactoring namspaces, moving common abstractions into abstractio…
9de2b95 
…ns namespace
alhardy added a commit that referenced this issue Jan 27, 2017
@alhardy
#50 more namespace refactoring
e25883e
alhardy added a commit that referenced this issue Jan 27, 2017
@alhardy
#50 more namespace refactoring
1e39890
alhardy added a commit that referenced this issue Jan 27, 2017
@alhardy
#50 more namespace refactoring
d908e1a
alhardy added a commit that referenced this issue Jan 27, 2017
@alhardy
#50 expose metric value retrieval from metrics snapshot
bceeb28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
1.0.0-beta5
Development

No branches or pull requests
1 participant
@alhardy