Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review metrics recorded by middleware extensions #52

Closed
alhardy opened this issue Dec 23, 2016 · 1 comment
Closed

Review metrics recorded by middleware extensions #52

alhardy opened this issue Dec 23, 2016 · 1 comment

Comments

@alhardy
Copy link
Collaborator

alhardy commented Dec 23, 2016

Ensure all metrics recorded by app metrics middleware extensions are correct and simplify where possible, also ensure metrics reporting are easily discoverable in influxdb for example.

@alhardy alhardy added this to the 1.0.0-beta4 milestone Dec 23, 2016
@alhardy alhardy removed this from the 1.0.0-beta4 milestone Jan 3, 2017
@alhardy alhardy added this to the 1.0.0-beta5 milestone Jan 3, 2017
@alhardy
Copy link
Collaborator Author

alhardy commented Jan 27, 2017

Metrics recorded correctly, an improvement to the per request timer middleware would be to have a single timer but tag the metric per endpoint so for example a table could automatically be show all the api's endpoints without having to manually create a new chart.

Work scheduled here - #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant