Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sampling tidy up making reservoir implementations pluggable #69

Closed
alhardy opened this issue Jan 20, 2017 · 0 comments
Closed

Sampling tidy up making reservoir implementations pluggable #69

alhardy opened this issue Jan 20, 2017 · 0 comments
Labels
breaking change
Milestone
1.0.0-beta5

Comments

@alhardy
Copy link
Collaborator

alhardy commented Jan 20, 2017 •
edited

Keep Uniform, Exponentially Decaying and Sliding window as out of box reservoir implementations but allow extensibility on reservoir implementations. The HdrHistogram implementation can be in is own package
@alhardy alhardy added this to the 1.0.0-beta5 milestone Jan 20, 2017
alhardy added a commit that referenced this issue Jan 21, 2017
@alhardy
#69 moved hdr histogram from core package, created abstraction packag…
94d3aea 
…e (will move abstractions from core package), cleaning up implementation providing a default global sampling type, renaming reservoir implementation based on the algorithm they implement, custom reservoirs implementations can now be plugged in
@alhardy alhardy changed the title Move Sampling code to separate project Sampling tidy up making reservoir implementations pluggable Jan 21, 2017
alhardy added a commit that referenced this issue Jan 21, 2017
@alhardy
#69 fixing broken reporter teests, excluding hdr histogram from cover…
ca33f49 
…age for now, likely to change the implementation
alhardy added a commit that referenced this issue Jan 25, 2017
@alhardy
#69 scrapped the idea of having an abstractions project, it should be…
d9a7a9b 
… fine for extenstion projects to refrence the core package which doesnt contain many dependencies
@alhardy alhardy closed this as completed Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
1.0.0-beta5
Development

No branches or pull requests
1 participant
@alhardy