Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for base states #50

Open
ali-ramadhan opened this issue Feb 3, 2020 · 1 comment
Open

Adding support for base states #50

ali-ramadhan opened this issue Feb 3, 2020 · 1 comment

Comments

@ali-ramadhan
Copy link
Owner

Not sure how important this is given that we're not super worried about truncation or rounding errors in the vertical momentum equation right now. From my understanding, the errors are more severe when running with terrain-following coordinates so perhaps we don't even base states to do most of what we want to do.

A big reason to add base states though is to provide hydrostatic states in which we can initialize simulations without worrying about transient acoustic waves (see issue #42).

It would also reduce the amount of boilerplate code by a lot. Currently the verification experiments spent a non-trivial amount of code setting up a dry adiabatic atmosphere and running it to steady state. Users cannot be expected to do this.

@ali-ramadhan
Copy link
Owner Author

I should mention that the amount of refactoring is pretty small if we add base states (and evolve the perturbations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant