feat(Tree): add renderChildNodes prop #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feat/1.19.0 #1273 +/- ##
===============================================
+ Coverage 90.95% 90.96% +<.01%
===============================================
Files 260 260
Lines 14346 14348 +2
Branches 4577 4576 -1
===============================================
+ Hits 13049 13051 +2
Misses 1275 1275
Partials 22 22
Continue to review full report at Codecov.
|
myronliu347
force-pushed
the
feat-tree
branch
from
bcc39f4
to
f71cb1a
Compare
youluna
requested changes
Oct 30, 2019
docs/tree/demo/render-child-nodes.md
Outdated
| @@ -0,0 +1,79 @@ | |||
| # 平铺叶子节点 | |||
|
|
|||
| - order: 2 | |||
There was a problem hiding this comment.
order决定了当前demo在最终demo页面上的顺序，不要有重复，已经有order2了
docs/tree/demo/render-child-nodes.md
Outdated
| :::lang=en-us | ||
| # Tile leaf nodes | ||
|
|
||
| - order: 2 |
docs/tree/demo/render-child-nodes.md
Outdated
| render() { | ||
| return <Tree checkable renderChildNodes={(nodes) => { | ||
| if (nodes.filter((node) => !node.props.children || node.props.children.length === 0).length !== nodes.length) { | ||
| return null; |
There was a problem hiding this comment.
renderChildNodes 返回null 表示按照原状态渲染有点奇怪，看下是改实现还是改api名字
docs/tree/demo/render-child-nodes.md
Outdated
| if (nodes.filter((node) => !node.props.children || node.props.children.length === 0).length !== nodes.length) { | ||
| return null; | ||
| } | ||
| return <ul className="next-tree-child-tree custom-leaf-tree">{nodes}</ul> |
youluna
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.