Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upload): add param to control upload list #4500

Merged

Conversation

owenchen1004
Copy link
Contributor

现有的upload组件无法隐藏上传列表,在listType属性上加了“none”参数来控制上传列表的显隐,默认显示上传列表。

Fixes #4496

src/upload/upload.jsx Show resolved Hide resolved
@YSMJ1994
Copy link
Contributor

还有,测试用例需要补充一下,关于listType为none的情况和不为none的情况是否符合预期

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e0250e) 90.60% compared to head (37e82a3) 90.60%.
Report is 1 commits behind head on master.

❗ Current head 37e82a3 differs from pull request most recent head 4637bcf. Consider uploading reports for the commit 4637bcf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4500      +/-   ##
==========================================
- Coverage   90.60%   90.60%   -0.01%     
==========================================
  Files         305      305              
  Lines       18051    18051              
  Branches     5546     5546              
==========================================
- Hits        16356    16355       -1     
- Misses       1674     1675       +1     
  Partials       21       21              
Files Coverage Δ
src/switch/index.jsx 97.67% <ø> (ø)
src/upload/upload.jsx 79.06% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@owenchen1004
Copy link
Contributor Author

还有,测试用例需要补充一下,关于listType为none的情况和不为none的情况是否符合预期

测试用例已补充

@YSMJ1994 YSMJ1994 added Next release issues to close in next release and removed PR: review-changes-request Next release issues to close in next release labels Oct 31, 2023
@YSMJ1994 YSMJ1994 merged commit bf5bf12 into alibaba-fusion:master Oct 31, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Upload]upload组件上传文件后的文件列表可以关掉吗?
2 participants