Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Cascader): first level menu always can collapse next level menus #4502

Merged
merged 3 commits into from
Oct 31, 2023
Merged

fix(Cascader): first level menu always can collapse next level menus #4502

merged 3 commits into from
Oct 31, 2023

Conversation

YSMJ1994
Copy link
Contributor

No description provided.

@YSMJ1994 YSMJ1994 linked an issue Oct 30, 2023 that may be closed by this pull request
[CascaderSelect]CascaderSelect 级联选择未能收缩二级菜单 #4472
Closed
@eternalsky
Copy link
Contributor

标题？

@eternalsky
Copy link
Contributor

@YSMJ1994 这个标题是不是有点问题

@YSMJ1994 YSMJ1994 changed the title 4472 cascaderselectcascaderselect fix(Cascader): add setExpandedBy to differentiate the change type at getDerivedStateFromProps Oct 30, 2023
@YSMJ1994 YSMJ1994 changed the title fix(Cascader): add setExpandedBy to differentiate the change type at getDerivedStateFromProps fix(Cascader): first level menu always can collapse level 2 menus Oct 31, 2023
@YSMJ1994 YSMJ1994 changed the title fix(Cascader): first level menu always can collapse level 2 menus fix(Cascader): first level menu always can collapse next level menus Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e0250e) 90.60% compared to head (1daabea) 90.64%.
Report is 1 commits behind head on master.

❗ Current head 1daabea differs from pull request most recent head 23d15e7. Consider uploading reports for the commit 23d15e7 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4502      +/-   ##
==========================================
+ Coverage   90.60%   90.64%   +0.03%     
==========================================
  Files         305      305              
  Lines       18051    18055       +4     
  Branches     5546     5550       +4     
==========================================
+ Hits        16356    16366      +10     
+ Misses       1674     1668       -6     
  Partials       21       21
Files Coverage Δ
src/cascader/cascader.jsx 92.12% <100.00%> (+0.38%) ⬆️
src/switch/index.jsx 97.67% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eternalsky eternalsky merged commit c8ed0b5 into master Oct 31, 2023
19 checks passed
@eternalsky eternalsky deleted the 4472-cascaderselectcascaderselect branch October 31, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eternalsky eternalsky eternalsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CascaderSelect]CascaderSelect 级联选择未能收缩二级菜单
2 participants
@YSMJ1994 @eternalsky