fix(Table): change the way to use of sortable #4514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4514 +/- ##
===========================================
- Coverage 90.66% 11.52% -79.15%
===========================================
Files 305 305
Lines 18066 17903 -163
Branches 5437 5289 -148
===========================================
- Hits 16380 2063 -14317
- Misses 1665 15836 +14171
+ Partials 21 4 -17 ☔ View full report in Codecov by Sentry. |
YSMJ1994
requested changes
Nov 15, 2023
YSMJ1994
reviewed
Nov 15, 2023
docs/table/demo/dragable.md
Outdated
| @@ -178,14 +178,14 @@ class Demo extends React.Component { | |||
| }; | |||
| render() { | |||
| return ( | |||
| <DragDropContextProvider backend={HTML5Backend}> | |||
| <DragDropContext backend={HTML5Backend}> | |||
There was a problem hiding this comment.
DragDropContext不是一个组件，你仔细看一下我的那个demo
YSMJ1994
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4489