Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Overlay): support show-hide in nested scroll component #4517

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

kyokaxin
Copy link
Contributor

@kyokaxin kyokaxin commented Nov 8, 2023

close #4481

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0fed23b) 90.76% compared to head (080eb55) 90.75%.

❗ Current head 080eb55 differs from pull request most recent head 21d665e. Consider uploading reports for the commit 21d665e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4517      +/-   ##
==========================================
- Coverage   90.76%   90.75%   -0.01%     
==========================================
  Files         305      305              
  Lines       17903    17903              
  Branches     5405     5289     -116     
==========================================
- Hits        16249    16248       -1     
- Misses       1637     1638       +1     
  Partials       17       17              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/overlay/index-spec.js Outdated Show resolved Hide resolved
@YSMJ1994 YSMJ1994 merged commit 8cef2a1 into master Nov 9, 2023
18 of 19 checks passed
@YSMJ1994 YSMJ1994 deleted the fix-issue-4481 branch November 9, 2023 03:37
YunMeng99 pushed a commit that referenced this pull request Dec 12, 2023
* fix(Overlay): support show-hide in nested scroll component

---------

Co-authored-by: chenkeyao.chenkeya <chenkeyao.chenkeya@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants