Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): Modify the props of the title element in the table header #4522

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

kyokaxin
Copy link
Contributor

close #4370

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dcd19d7) 90.75% compared to head (7c86864) 11.52%.
Report is 3 commits behind head on master.

❗ Current head 7c86864 differs from pull request most recent head 52ba127. Consider uploading reports for the commit 52ba127 to get more accurate results

Files Patch % Lines
src/table/base/cell.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4522       +/-   ##
===========================================
- Coverage   90.75%   11.52%   -79.24%     
===========================================
  Files         305      305               
  Lines       17903    17903               
  Branches     5289     5290        +1     
===========================================
- Hits        16248     2063    -14185     
- Misses       1638    15836    +14198     
+ Partials       17        4       -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@YSMJ1994 YSMJ1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看了下用户的demo,给 column 的title传递了一个Input 元素,你这里改的地方不对,因该是L101 行的cellProps需要根据 type=header的情况传空

而且也没有补充测试用例,这导致了你的改动并没有经过验证

@YSMJ1994 YSMJ1994 self-requested a review November 15, 2023 14:06
@YSMJ1994 YSMJ1994 merged commit bde3b4e into master Nov 15, 2023
19 checks passed
@YSMJ1994 YSMJ1994 deleted the fix-issue-4370 branch November 15, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table]table title用fusion input组件无法显示value && 无法输入
2 participants