Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Cascader): cascader props value changed then expandedValue did no… #4531

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

seven-lh
Copy link
Contributor

@seven-lh seven-lh commented Nov 16, 2023

close #3954

@seven-lh
Copy link
Contributor Author

cascader props value expanded Value

@seven-lh seven-lh closed this Nov 21, 2023
@YSMJ1994 YSMJ1994 reopened this Nov 21, 2023
@YSMJ1994 YSMJ1994 linked an issue Nov 21, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4fc9f0e) 90.77% compared to head (645fe48) 90.91%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4531      +/-   ##
==========================================
+ Coverage   90.77%   90.91%   +0.13%     
==========================================
  Files         305      305              
  Lines       17905    17935      +30     
  Branches     5291     5305      +14     
==========================================
+ Hits        16253    16305      +52     
+ Misses       1635     1613      -22     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eternalsky eternalsky requested review from eternalsky and removed request for eternalsky November 30, 2023 03:52
src/cascader/cascader.jsx Outdated Show resolved Hide resolved
@eternalsky
Copy link
Contributor

eternalsky commented Nov 30, 2023

@YSMJ1994 这个 pr 解决的 issue,貌似与另一个 pr 有些关联:c8ed0b5 。可以一起来看一下。另一个 pr 中,加入了 state.isExpandedValueSetByAction 限制了根据值重置 expandedValue 的逻辑,而这个 pr 关联的 issue 貌似就是这个的反例,即value 变化从外部而外,但 isExpandedValueSetByAction 并未改变,导致 expandedValue 没有重置。

@YSMJ1994 YSMJ1994 merged commit 8fece00 into master Dec 6, 2023
19 checks passed
@YSMJ1994 YSMJ1994 deleted the fix-for-3954 branch December 6, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants