Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): should support Header and Body follow the TableGroupHeade… #4550

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

kyokaxin
Copy link
Contributor

…r when it locks the columns

close #4396

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d1bca3) 90.87% compared to head (b8b9632) 90.89%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4550      +/-   ##
==========================================
+ Coverage   90.87%   90.89%   +0.02%     
==========================================
  Files         305      305              
  Lines       17905    17923      +18     
  Branches     5290     5299       +9     
==========================================
+ Hits        16271    16292      +21     
+ Misses       1617     1614       -3     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@YSMJ1994 YSMJ1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

实际上就是 list.body没有调用 getNode 和 onFixedScrollSync 同步信息的问题,只要改 src/table/list/body.jsx一个文件就可以修复这个问题,其它都是没必要的改动

还有测试用例即使是issue用例,也需要精简后再录入,要符合最小复现原则,数据需要通过计算生成,不要使用一长串的业务数据。

Copy link
Contributor

@YSMJ1994 YSMJ1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试用例是无效运行,assert在done之后

@YSMJ1994 YSMJ1994 self-requested a review November 29, 2023 15:53
Copy link
Contributor

@YSMJ1994 YSMJ1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YSMJ1994 YSMJ1994 merged commit a11365a into master Nov 29, 2023
19 checks passed
@YSMJ1994 YSMJ1994 deleted the fix-issue-4396 branch November 29, 2023 15:55
owenchen1004 pushed a commit to owenchen1004/next that referenced this pull request Dec 5, 2023
…and StickyLock, close 4396 (alibaba-fusion#4550)

* fix(Table): should support Header and Body follow the TableGroupHeader when it locks the columns

* fix(Table): delete useless code

* fix(Table): adjust test spec for alibaba-fusion#4396

---------

Co-authored-by: 珵之 <chengzhi.zpc@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table]使用Table.GroupHeader,并锁列,表头未随表格滚动
2 participants