-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Table): should support Header and Body follow the TableGroupHeade… #4550
Conversation
…r when it locks the columns
7c7fd12
to
041af08
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4550 +/- ##
==========================================
+ Coverage 90.87% 90.89% +0.02%
==========================================
Files 305 305
Lines 17905 17923 +18
Branches 5290 5299 +9
==========================================
+ Hits 16271 16292 +21
+ Misses 1617 1614 -3
Partials 17 17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
实际上就是 list.body没有调用 getNode 和 onFixedScrollSync 同步信息的问题,只要改 src/table/list/body.jsx一个文件就可以修复这个问题,其它都是没必要的改动
还有测试用例即使是issue用例,也需要精简后再录入,要符合最小复现原则,数据需要通过计算生成,不要使用一长串的业务数据。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
测试用例是无效运行,assert在done之后
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…and StickyLock, close 4396 (alibaba-fusion#4550) * fix(Table): should support Header and Body follow the TableGroupHeader when it locks the columns * fix(Table): delete useless code * fix(Table): adjust test spec for alibaba-fusion#4396 --------- Co-authored-by: 珵之 <chengzhi.zpc@alibaba-inc.com>
…r when it locks the columns
close #4396