Fix/table scroll to row #4648
Merged
Fix/table scroll to row #4648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4648 +/- ##
=======================================
Coverage 90.93% 90.93%
=======================================
Files 305 305
Lines 17922 17922
Branches 5295 5295
=======================================
Hits 16297 16297
Misses 1608 1608
Partials 17 17 ☔ View full report in Codecov by Sentry. |
YSMJ1994
requested changes
Dec 12, 2023
There was a problem hiding this comment.
- PR里混杂了overlay的代码，是否是基于master检出的分支？
- 从实际含义上来说，新增的api命名为 keepForwardRenderRows 更合理
- demo内的解释不够清晰，参考: 虚拟滚动会卸载滚动到视区之外的行，行合并利用td元素的rowSpan属性，需要在合并的第一行设置rowSpan属性，若因滚动视区外卸载了该行，则会导致行合并失效，可以使用 keepForwardRenderRows 设置向前保留一定行数不被卸载，从而使行合并始终生效（设置 keepForwardRenderRows 大于 max rowSpan即可）
- demo缺少交互演示设置不同 keepForwardRenderRows 的效果
- 需要在table/base.jsx的propTypes内添加该api的jsdoc，文档api会依据这个jsdoc自动生成的
YSMJ1994
requested changes
Dec 13, 2023
|
测试用例我后面帮你优化一下，你先改前面的内容 @YunMeng99 |
YSMJ1994
added a commit
that referenced
this pull request
Dec 13, 2023
eternalsky
approved these changes
Dec 14, 2023
YSMJ1994
approved these changes
Dec 14, 2023
YSMJ1994
force-pushed
the
fix/Table-scrollToRow
branch
from
3b961d6
to
78a97d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.