-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Issues #1696 添加持久化支持,可选持久化选项:nacos、apollo、zookeeper ; 修改 README.md 说明文档 #1711
Conversation
Signed-off-by: jiajiangnan <jiajiangnan.office@foxmail.com>
代码已提交,麻烦 review |
…es.java matched to application.properties Signed-off-by: jiajiangnan <jiajiangnan.office@foxmail.com>
has commit the Properties file that was forgotten to commit, which will cause rules couldn't persist into datassource of config-center. So sorry for it. |
Signed-off-by: jiajiangnan <jiajiangnan.office@foxmail.com>
Signed-off-by: jiajiangnan <jiajiangnan.office@foxmail.com>
…okeeper. Signed-off-by: jiajiangnan <jiajiangnan.office@foxmail.com>
@sczyh30 Could you please take a time to help review the code? Thanks ~ |
没人管了? |
…atasource.Converter" bean in ZookeeperApiClient when datasource is zookeeper . Signed-off-by: jiajiangnan <jiajiangnan.office@foxmail.com>
Signed-off-by: jiajiangnan <jiajiangnan.office@foxmail.com>
搞不懂为什么官方不添加持久化功能的神操作啊,开源虽然是阉割版,但是dashboard应该是生产可用的啊。 |
以jar启动 不兼容-D的配置方式? 修改代码里面的application.properties启动OK |
@jiajiangnan |
目前测试 是可用的 |
jiajiangnan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
mark |
@slin1972 启动不知道为什么不兼容-D。 我试了试 --datasource.provider=nacos 这种方式,目前zk报错
|
CuratorFramework zkClient = CuratorFrameworkFactory.newClient("localhhost:2181", exponentialBackoffRetry); |
When will this feature be available? Too slow. |
我以为过去一年了,应该合并到release了吧,进来一看,还是open的呀,失望。。。 |
一年多了,是什么原因导致没合并到master分支呢? |
代码能给我一下吗?
发自我的iPhone
…------------------ 原始邮件 ------------------
发件人: ruoshuixuelabi ***@***.***>
发送时间: 2021年9月10日 15:57
收件人: alibaba/Sentinel ***@***.***>
抄送: kuangyoubo ***@***.***>, Comment ***@***.***>
主题: 回复:[alibaba/Sentinel] Fixes Issues #1696 添加持久化支持,可选持久化选项:nacos、apollo、zookeeper ; 修改 README.md 说明文档 (#1711)
一年多了,是什么原因导致没合并到master分支呢?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
@jiajiangnan 你那个分支是哪一个,我看看 |
@slin1972 你那个方式是修改源码之后的还是官方打包的jar包就已经支持了呢? |
Signed-off-by: jiajiangnan jiajiangnan.office@foxmail.com
Fixes Issues #1696
1、添加持久化支持,可选持久化选项:nacos、apollo、zookeeper
2、修改 README.md 和 Sentinel_Dashboard_Feature.md 说明文档
Describe what this PR does / why we need it
Extended persistence module. We can persistent the configs of rules into config-center like nacos,apollo,zookeeper. It can make sure the rule configs could make work even if we restart the sentinel-dashbord or sentinel client in applications. Now,this PR is also adapte to the web views,the views is not needed to modify at all.
Does this pull request fix one issue?
Fixes Issues #1696
Describe how you did it
1、Add config items in springboot config files such as application.properties. These config items is the settings that config-center needed. When sentinel-dashboard is starting, Spring will identify which config-center is configed, or used the memory as the default store.
2、All kinds of config-center has it's self Rules ManageClient which constructed by @configuration, but only one will be construct by sentinel-dashboard started because the @configuration has condition. The only one is that be configed in application.preperties. We can manage the rules through ManageClient.
3、There is a condition sentences to ensure that the old code still worked. If the item added in application is memory, then use the default "sentinelApiClient", else use the Client constructed by @configuration.
Describe how to verify it
Before:
1、add the following config items in application.properties:
datasource.provider=nacos
datasource.provider.nacos.server-addr=ip:port
2、run sentinel-dashboard
3、application which inclues sentinel-client ,config to the same config-center
After:
1、manage rules in sentinel-dashboard, search the configs in config-center, do some request in application which inclues sentinel-client
2、manage rules in config-center, search the rules in dashboard, do some request in application which inclues sentinel-client
3、Because of this PR has adapt the default memory store,and also adapt the web view, so we can test directly in the old web pages.
Special notes for reviews
1、this PR has adapt the default memory store,and also adapt the web view, so we can test directly in the old web pages.