Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] SofaRpcFallbackRegistryTest has order dependent tests #3281

Closed
SaaiVenkat opened this issue Nov 30, 2023 · 0 comments · Fixed by #3282
Closed

[BUG] SofaRpcFallbackRegistryTest has order dependent tests #3281

SaaiVenkat opened this issue Nov 30, 2023 · 0 comments · Fixed by #3282
Labels
area/test Issue or PR related to test cases

Comments

@SaaiVenkat
Copy link
Contributor

SaaiVenkat commented Nov 30, 2023

Issue Description

Type: bug report

Describe what happened

Describe what you expected to happen

  • The unit tests in com.alibaba.csp.sentinel.adapter.sofa.rpc.fallback.SofaRpcFallbackRegistryTest should pass when run in any order

How to reproduce it (as minimally and precisely as possible)

  • In com.alibaba.csp.sentinel.adapter.sofa.rpc.fallback.SofaRpcFallbackRegistryTest, run the following unit tests in order
    • testCustomFallback()
    • testDefaultFallback()
  • Running the tests in the above manner will produce java.lang.AssertionError
java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at com.alibaba.csp.sentinel.adapter.sofa.rpc.fallback.SofaRpcFallbackRegistryTest.testDefaultfallback(SofaRpcFallbackRegistryTest.java:42)

Tell us your environment

  • Sentinel: 1.8.6
  • OS: Mac OS X 14.0 aarch64
  • Java: 17.0.9 or 1.8.0_381

Anything else we need to know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test Issue or PR related to test cases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants