Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding prefix to Dubbo service resource name in Sentinel Dubbo Adapter #427

Closed
zhongxunking opened this issue Jan 17, 2019 · 8 comments · Fixed by #859
Closed

Support adding prefix to Dubbo service resource name in Sentinel Dubbo Adapter #427

zhongxunking opened this issue Jan 17, 2019 · 8 comments · Fixed by #859
Labels
area/integrations Issues or PRs related to integrations with open-source components good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.

Comments

@zhongxunking
Copy link

Dubbo适配器提供的资源名目前没有前缀,只是包路径+类名。导致在控制台看到时不能直观的看出是Dubbo调用。可否增加前缀以示区别。比如服务提供者使用dubbo-provider,服务消费者使用dubbo-consumer

@sentinel-bot
Copy link
Collaborator

Hi @zhongxunking, we detect non-English characters in the issue. This comment is an auto translation from @sentinel-bot to help other users to understand this issue.
We encourage you to describe your issue in English which is more friendly to other users.

The resource name provided by the Dubbo adapter adds the Dubbo prefix.

The resource name provided by the Dubbo adapter currently has no prefix, just the package path + class name. It is not intuitive to see that the Dubbo call is made when you see it in the console. Can I add a prefix to show the difference. For example, the service provider uses dubbo-provider, and the service consumer uses dubbo-consumer.

@sentinel-bot sentinel-bot changed the title Dubbo适配器提供的资源名增加Dubbo前缀 The resource name provided by the Dubbo adapter adds the Dubbo prefix. Jan 17, 2019
@sczyh30 sczyh30 changed the title The resource name provided by the Dubbo adapter adds the Dubbo prefix. Support adding prefix to Dubbo service resource name in Sentinel Dubbo Adapter Jan 17, 2019
@sczyh30 sczyh30 added kind/enhancement Category issues or prs related to enhancement. area/integrations Issues or PRs related to integrations with open-source components labels Jan 17, 2019
@sczyh30
Copy link
Member

sczyh30 commented Jan 17, 2019

Hi, thanks for your suggestion. For this, we need to consider compatibility with previous versions. Maybe we can add a property to control whether the resource name has a common prefix and configure the common prefix.

@zhongxunking
Copy link
Author

thanks, it is good. which version of sentinel will provide the feature?

@sczyh30 sczyh30 added the good first issue Good for newcomers label Jan 18, 2019
@sczyh30
Copy link
Member

sczyh30 commented Jan 30, 2019

Contribution is welcomed~

@linlinisme
Copy link
Collaborator

I have a question: If the dubbo service shows the prefix, then the configuration rules should be prefixed?

@sczyh30
Copy link
Member

sczyh30 commented May 29, 2019

I have a question: If the dubbo service shows the prefix, then the configuration rules should be prefixed?

If the Dubbo service resource is added with the prefix, then when we configure rules it should also be prefixed. This is not compatible with existing rules.

@linlinisme
Copy link
Collaborator

So is it necessary to add the prefix?

@sczyh30
Copy link
Member

sczyh30 commented Aug 14, 2019

thanks, it is good. which version of sentinel will provide the feature?

This will be introduced in 1.7.0. See #859 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/integrations Issues or PRs related to integrations with open-source components good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants