Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace usleep for cross platform support #54

Closed
2 tasks
RainMark opened this issue Mar 8, 2022 · 2 comments · Fixed by #56
Closed
2 tasks

replace usleep for cross platform support #54

RainMark opened this issue Mar 8, 2022 · 2 comments · Fixed by #56
Assignees
@qicosmos

Comments

@RainMark
Copy link
Collaborator

RainMark commented Mar 8, 2022

Search before asking

  • I searched the issues and found no similar issues.

What happened + What you expected to happen

use std::this_thread::sleep_for to replace all usleep

previous discuss at: #51 (comment)

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@qicosmos qicosmos self-assigned this Mar 8, 2022
@qicosmos
Copy link
Collaborator

qicosmos commented Mar 8, 2022 •
edited

How about add a USleep function in util.h or common.h to make minimal modification?

@RainMark
Copy link
Collaborator Author

RainMark commented Mar 8, 2022

How about add a USleep function in util.h or common.h to make minimal modification?

nop, all be one line and just used in test

@qicosmos qicosmos mentioned this issue Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qicosmos qicosmos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cross platform]remove usleep qicosmos/async_simple
2 participants
@qicosmos @RainMark